When should a developer start marketing their product?

Short answer

Before it is finished. The strongest signal you can get is whether anyone will give you an email address for a product that does not exist yet, and that costs a weekend to test. Building for six months and then thinking about distribution is the single most common way indie projects fail.